Home General
New Blog Posts: Merging Reports - Part 1 and Part 2

ShowData menuitem

edited September 2009 in General
Hi,

RbPro 11.06, Delphi 2006, Vista SP2



The checkmark of the ShowData menuitem does not follow the state of the
designer.

I think the following line is missing in procedure
TppDesignViewMenu.UpdateStatus

FShowData.Checked := WorkspaceController.WorkspaceView.LiveData;


Also it seems that the saved preference value is ignored. Not sure about
this, could be the way we create the designer window. But i noticed that in
TppDesigner.CreateDesignerWindow during the creation of the
TppDesignerWindow the preferences are first loaded by
TppDesignerWorkSpaceView.LoadPreferences. After that DesignerWindow.LiveDta
is overwritten with TppDesigner.FShowData. And TppDesigner.FShowData is
always true at that point.
For now i have solved it with an extra call to LoadPrefences after the
creation of the designer.


Regards,

Max Paay
Quadrant Software bv.
The Netherlands.



__________ Information from ESET NOD32 Antivirus, version of virus signature database 4468 (20090929) __________

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com

Comments

  • edited September 2009

    Thanks for pointing this out. This fix will be included in the code base
    going forward.

    If you want Preferences to take precedence over TppDesigner property values
    then calling LoadPreferences after creating the designer is a good idea. I
    we change this now, it would break other developers' existing code that are
    relying on the TppDesigner property values to override preferences.

    --
    Nard Moseley
    Digital Metaphors
    www.digital-metaphors.com

    Best regards,

    Nard Moseley
    Digital Metaphors
    www.digital-metaphors.com
  • edited October 2009
    Thanks Nard,

    Glad to be of some help and i leave the extra LoadPreferences in then.


    Regards,

    Max Paay
    Quadrant Software bv.
    The Netherlands.




    __________ Information from ESET NOD32 Antivirus, version of virus signature database 4480 (20091005) __________

    The message was checked by ESET NOD32 Antivirus.

    http://www.eset.com
This discussion has been closed.